Revise vector operations in SolverIDR to improve performance #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Sep 12, 2022
include/deal.II/lac/solver_idr.h
Outdated
| { | ||
| double beta = phi(k) / M(k, k); | ||
| r.add(-1.0 * beta, G[k]); | ||
| const double beta = phi(k) / M(k, k); |
There was a problem hiding this comment.
Do you want me to use VectorType::value_type like in the other PR? I can do that, if you agree with changing the matrix types and all other stuff currently in double variables, such as this one here:
dealii/include/deal.II/lac/solver_idr.h
Lines 423 to 424 in fb2242d
Or are you suggesting something else?
There was a problem hiding this comment.
Do you want me to use VectorType::value_type like in the other PR? I can do that, if you agree with changing the matrix types and all other stuff currently in double variables, such as this one here:
Yes, sounds reasonable 👍
kronbichler
force-pushed
the
improve_idr
branch
from
fb6c89e
to
0fc6a4d
Compare
tjhei
approved these changes
Sep 13, 2022
peterrum
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.