DataOutResample for multiple components #14258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
force-pushed
the
DataOutResample_multiple_components
branch
4 times, most recently
from
8bf608e
to
29d31b1
Compare
peterrum
commented
Sep 13, 2022
Comment on lines
+163
to
+167
| for (unsigned int comp = 0; comp < dh.get_fe_collection().n_components(); | ||
| ++comp) | ||
| { | ||
| const auto values = VectorTools::point_values<1>( | ||
| rpe, dh, data_ptr->vector, VectorTools::EvaluationFlags::avg, comp); |
There was a problem hiding this comment.
This is the only relevant change. Loop over all components and call VectorTools::point_values for each component.
|
/rebuild |
marcfehling
approved these changes
Sep 13, 2022
|
|
||
| Assert(n_components == 1, | ||
| Assert(n_components == 1 && first_selected_component == 0, |
There was a problem hiding this comment.
That's the only place where you use first_selected_component, right? Did I overlook something?
There was a problem hiding this comment.
It is used here:
dealii/include/deal.II/numerics/vector_tools_evaluate.h
Lines 446 to 453 in 29d31b1
|
Would you document the new parameter in the header file? I would also like to have a test if that's alright :) |
peterrum
force-pushed
the
DataOutResample_multiple_components
branch
from
29d31b1
to
d9230d5
Compare
@marcfehling Done! |
marcfehling
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FYI @mschreter @jh66637