Make sure not to work with possibly uninitialized variables #14280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to a change in #14251, we would now not necessarily initialize a vector in the GMRES solver, see here:
dealii/include/deal.II/lac/solver_gmres.h
Line 598 in f28d4d1
In two of our tests, we would use
vector *= 0.0
to set its entries to zero, rather than the (more efficient)vector = 0.0
. The former accesses whatever content we have in the memory, which could beNaN
, which can then cause a floating point exception as in this test here: https://cdash.dealii.43-1.org/test/32205805 - while the latter is correct and makes sure we overwrite all content, includinginf
andnan
data, with the correct value0.