Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure not to work with possibly uninitialized variables #14280

Merged
merged 1 commit into from Sep 18, 2022

Conversation

kronbichler
Copy link
Member

Due to a change in #14251, we would now not necessarily initialize a vector in the GMRES solver, see here:

data[i]->reinit(temp, true);

In two of our tests, we would use vector *= 0.0 to set its entries to zero, rather than the (more efficient) vector = 0.0. The former accesses whatever content we have in the memory, which could be NaN, which can then cause a floating point exception as in this test here: https://cdash.dealii.43-1.org/test/32205805 - while the latter is correct and makes sure we overwrite all content, including inf and nan data, with the correct value 0.

@tjhei tjhei merged commit 221b8f1 into dealii:master Sep 18, 2022
@kronbichler kronbichler deleted the fix_uninitialized branch August 10, 2023 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants