Avoid undefined behavior warning #14283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
approved these changes
Sep 18, 2022
|
/rebuild |
kronbichler
approved these changes
Sep 18, 2022
marcfehling
reviewed
Sep 18, 2022
| @@ -1007,7 +1007,7 @@ ReferenceCell::n_lines() const | |||
| return 12; | |||
|
|
|||
| Assert(false, ExcNotImplemented()); | |||
There was a problem hiding this comment.
Suggested change
| Assert(false, ExcNotImplemented()); | |
| AssertThrow(false, ExcNotImplemented()); |
Shall we use an AssertThrow here to make sure that this part is never reached in both debug and release mode? What do you think?
There was a problem hiding this comment.
We don't use at such places AssertThrow.
There was a problem hiding this comment.
I agree; while we expect the code to not be reachable, the compiler will not know that and still generates the code also in release mode. Having a smaller function content makes the likelihood of the compiler to inline the function higher, making it a win overall. We have the debug mode for ensuring consistency of data.
masterleinad
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #14263
@kronbichler @peterrum: This was the only place, where the warning popped up for now.