Remove template parameter from FPArrayComparator #14294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronbichler
reviewed
Sep 20, 2022
Comment on lines
3416
to
3418
| Tensor<1, | ||
| FPArrayComparator<VectorizedArrayType>::width, | ||
| typename FPArrayComparator<VectorizedArrayType>::Number>> &t1, |
There was a problem hiding this comment.
Can't you just say
Suggested change
| Tensor<1, | |
| FPArrayComparator<VectorizedArrayType>::width, | |
| typename FPArrayComparator<VectorizedArrayType>::Number>> &t1, | |
| Tensor<1, width, Number>> &t1, |
here and below, since this is the definition of a member function?
peterrum
force-pushed
the
FPArrayComparator_Number
branch
from
a22baf0
to
541d777
Compare
kronbichler
approved these changes
Sep 20, 2022
|
I have added the "Do not merge" label since we first need to agree on #14293. |
peterrum
force-pushed
the
FPArrayComparator_Number
branch
from
541d777
to
a7c0d74
Compare
|
/rebuild |
peterrum
force-pushed
the
FPArrayComparator_Number
branch
from
a7c0d74
to
94a807d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... with the intention that it not only works for
VectorizedArray<Number>but also forNumber.In forllow up PRs, I plan
TablesTensorProductMatrixSymmetricSumCachedepends on #14293