Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TensorProductMatrixCreator namespace #14316

Merged
merged 1 commit into from Sep 29, 2022

Conversation

peterrum
Copy link
Member

I accidentally closed #14291. This contains the same content.

@peterrum
Copy link
Member Author

Do you plan tests for this? I think we should move forward here, so we can do it elsewhere.

I have locally a test for this function, where I compare the results with assembled/restricted matrices; but for that I need to get some more functions into deal.II.

This looks good in my opinion. I think one question I would have for the future is whether there is a way to avoid re-computing the same reference mass and stiffness matrices, as we might call this function many times with just the cell_extent and boundary_ids differing, but the same underlying 1D matrices.

Yes, this bothers me, too. One could shift the inner part of the function into separate function that takes the two reference matrices. But in that case one needs to handle hp manually. But I guess we can do that in a follow-up PR. In general, we should probably revisit the interfaces in the next weeks/months.

Comment on lines 22 to 33
#include <deal.II/base/quadrature.h>

#include <deal.II/fe/fe.h>

#include <deal.II/grid/grid_generator.h>
#include <deal.II/grid/tria.h>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The all-headers test fails. We need to include at least fe_values.h and dof_handler.h

const unsigned int n_overlap)
{
// 1) create element mass and siffness matrix (without overlap)
const auto [M_ref, K_ref, is_dg] =
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is C++17, so we need to work around it.

@kronbichler kronbichler merged commit 6113e8d into dealii:master Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants