Fix dimension selection in COMSOL mphtxt reader. #14374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
approved these changes
Oct 24, 2022
|
/rebuild |
masterleinad
approved these changes
Oct 24, 2022
|
I have that mesh, but it triggers further errors. I will add that to the test suite when I fix the underlying issue. This part of the change felt sufficiently obvious and self-contained. |
|
Lets add it later if there are more bugs that still need to be fixed. |
|
Yes, promised! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bug that shows up in a mailing list post by yy.wayne: The mesh in the file corresponds to
dim==2, spacedim==3, but the code we have does not consider the codimension-1 case and confuses dim and spacedim. Specifically, we need to ask dim, not spacedim, whether we are dealing with a cell or a face.This patch does not fix reading the file sent as part of the mailing list post, but it is a necessary first step.
/rebuild