Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor compressing arrays for VTU output. #14402

Merged
merged 1 commit into from Nov 9, 2022
Merged

Conversation

bangerth
Copy link
Member

@bangerth bangerth commented Nov 8, 2022

First step in a mini project I'm allowing myself today :-) My goal is to generate different parts of VTU files in parallel, rather than writing them sequentially to a stream. As a consequence, I will be moving towards building strings, rather than using streams.

/rebuild

@bangerth
Copy link
Member Author

bangerth commented Nov 8, 2022

First step for #14403.

@bangerth
Copy link
Member Author

bangerth commented Nov 8, 2022

The cuda tester fails with this message:

The user named '~ginggs' has no PPA named 'ubuntu/deal.ii-9.2.0-backports'

I don't believe that this is related to the PR here.

@drwells drwells mentioned this pull request Nov 8, 2022
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Unrelated to this PR: Is there any reason against using Utilities::pack?

@bangerth
Copy link
Member Author

bangerth commented Nov 9, 2022

Yes: pack() makes no guarantee how exactly it packs data (or whether it does so at all) except that it promises that you can unpack the data with unpack(). But here, the VTU format specifically prescribes how the compression has to happen, and that the resulting data then has to be uuencoded.

@kronbichler kronbichler merged commit c736a62 into dealii:master Nov 9, 2022
@bangerth bangerth deleted the vtu branch November 9, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants