Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print backends and architectures for Kokkos #14424

Merged
merged 1 commit into from Nov 19, 2022
Merged

Print backends and architectures for Kokkos #14424

merged 1 commit into from Nov 19, 2022

Conversation

masterleinad
Copy link
Member

@masterleinad masterleinad mentioned this pull request Nov 15, 2022
Merged
tjhei
tjhei approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice!

tjhei
tjhei reviewed Nov 15, 2022
View reviewed changes
cmake/setup_write_config.cmake
@@ -225,6 +225,10 @@ FOREACH(_feature ${_deal_ii_features_sorted})
_detailed("# TBB_VERSION = ${TBB_VERSION}\n")
ENDIF()

IF(_feature MATCHES "KOKKOS")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this also printing info if kokkos is disabled?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, it doesn't (but we agreed on making Kokkos a required dependency anyway).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, right.

@masterleinad
Copy link
Member Author

masterleinad commented Nov 15, 2022 •
edited

Sample output in detailed.log is

[...]
#        DEAL_II_WITH_KOKKOS set up with external dependencies
#            KOKKOS_BACKENDS = THREADS;SERIAL
#            KOKKOS_ARCHITECTURES = A64FX
#            KOKKOS_DIR = /tmp/Software/kokkos-install
#            KOKKOS_CXX_FLAGS = -march=armv8.2-a+sve
#            KOKKOS_LINKER_FLAGS = -DKOKKOS_DEPENDENCE -march=armv8.2-a+sve
#            KOKKOS_INCLUDE_DIRS = /tmp/Software/kokkos-install/include
#            KOKKOS_USER_INCLUDE_DIRS = /tmp/Software/kokkos-install/include
#            KOKKOS_LIBRARIES = /tmp/Software/kokkos-install/lib/libkokkoscore.a;/tmp/Software/kokkos-install/lib/libkokkoscontainers.a
[...]

@tamiko tamiko merged commit 812501a into dealii:master Nov 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rombur Rombur Rombur approved these changes

@tjhei tjhei tjhei approved these changes

@tamiko tamiko tamiko approved these changes

Assignees
No one assigned
Labels
Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@masterleinad @Rombur @tjhei @tamiko