Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Guard Belos code with macros #14425

Merged
merged 1 commit into from Nov 16, 2022
Merged

Guard Belos code with macros #14425

merged 1 commit into from Nov 16, 2022

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Nov 15, 2022

We assumed that Belos package was present without checking for it. Add a check and guard Belos code with macros

peterrum
peterrum approved these changes Nov 15, 2022
View reviewed changes
Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@masterleinad
Copy link
Member

/rebuild

@bangerth
Copy link
Member

Follow-up to #14352.

@bangerth
Copy link
Member

The cuda check fails. I believe that happens not just here.

@bangerth bangerth merged commit a88bce2 into dealii:master Nov 16, 2022
@Rombur Rombur deleted the belos branch November 21, 2022 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@bangerth bangerth bangerth approved these changes

@kronbichler kronbichler kronbichler approved these changes

@peterrum peterrum peterrum approved these changes

Assignees
No one assigned
Labels
External libraries ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Rombur @masterleinad @bangerth @kronbichler @peterrum