Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

step-85: mathjax typo in Section L^2-Error #14443

Merged
merged 1 commit into from Nov 29, 2022
Merged

Conversation

vyushut
Copy link
Contributor

@vyushut vyushut commented Nov 18, 2022

No description provided.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that actually works -- we have some trouble because the text here is also copied into the table of contents at the top. The safer choice would probably be to write it with HTML markup: <i>L<sup>2</sup></i>. I'd accept that patch if you want to update your pull request!

That said, many thanks for tackling these little things!

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant to click on "Request changes"...

examples/step-85/step-85.cc Outdated Show resolved Hide resolved
@tjhei
Copy link
Member

tjhei commented Nov 18, 2022

Thank you, Vladimir. 👍

@bangerth
Copy link
Member

Would you mind addressing the following error?

invalid author 'vyushut' without firstname and lastname

hint: for possible solutions, consult the webpage:
      https://github.com/dealii/dealii/wiki/Commit-authorship

@vyushut
Copy link
Contributor Author

vyushut commented Nov 20, 2022 via email

@bangerth
Copy link
Member

@vyushut ping?

@vyushut
Copy link
Contributor Author

vyushut commented Nov 28, 2022

@bangerth respond!
Sorry for being late, I'm going to finish this PR today.

@bangerth
Copy link
Member

@vyushut I believe that the system will want you to change things retroactively for the previous commits as well. You might want to "squash" the three commits into one and use the username of the last commit.

@vyushut
Copy link
Contributor Author

vyushut commented Nov 29, 2022

For some reason I couldn't make the squash working. Instead, I edited the authorship of two commits with the old user.name locally and merged it with the remote.

@bangerth
Copy link
Member

No, that's not making it any better -- now you have 7 commits for a one-line change :-)

Maybe the easiest way to fix this is to close this PR and open another one that contains only one commit with the one-line change and with the user-name correctly set.

@marcfehling marcfehling merged commit e674d63 into dealii:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants