New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Kokkos link libraries to Trilinos link libraries #14457
Merged
tamiko
merged 1 commit into
dealii:master
from
masterleinad:add_kokkos_libraries_to_trilinos
Nov 30, 2022
Merged
Add Kokkos link libraries to Trilinos link libraries #14457
tamiko
merged 1 commit into
dealii:master
from
masterleinad:add_kokkos_libraries_to_trilinos
Nov 30, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
approved these changes
Nov 23, 2022
Working on it. 😄 |
/rebuild |
masterleinad
force-pushed
the
add_kokkos_libraries_to_trilinos
branch
from
November 25, 2022 13:49
534c9d0
to
0a6272f
Compare
masterleinad
force-pushed
the
add_kokkos_libraries_to_trilinos
branch
from
November 28, 2022 14:22
0a6272f
to
1974e59
Compare
I can't compile my project anymore after this PR. It works when I revert 1974e59. Cmake confirms it found Kokkos when configuring deal.II. But when I try to link my project against the deal.II installation I get:
I deleted both 'build' directories for deal.II and my side project and configured and built everything from scratch. |
sigh I hope we can soon do this properly with #14491. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxes #14454. When we support
target_link_libraries
for external dependencies, we should be able to get rid of all these hacks.