Cleanup reinit() of PETSc/Trilinos BlockVector. #14476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcfehling
force-pushed
the
blockreinit
branch
10 times, most recently
from
d8dcf62
to
76cabec
Compare
marcfehling
force-pushed
the
blockreinit
branch
from
76cabec
to
931b472
Compare
kronbichler
approved these changes
Nov 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
n_blocks()returns anunsigned int. I matched types in loops.resize()does nothing when called with same size. We don't need to check for differing sizes beforehand.collect_sizes()updates theBlockIndicesobject. Although we can omit this part in assignment or copy operations, it's better to keep it up-to-date and rather be safe than sorry.block(i)returns the i-th component. Depending on the context, I found it easier to read to use eitherblock(i)orcomponent[i].