Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #14511

Merged
merged 2 commits into from Dec 1, 2022
Merged

Fix typos #14511

merged 2 commits into from Dec 1, 2022

Conversation

luzpaz
Copy link
Contributor

@luzpaz luzpaz commented Dec 1, 2022

Various typos

Various typos
@marcfehling
Copy link
Member

Our CI is complaining about an indentation problem. Please run make indent to fix the problem. If you end up with multiple commit, you can squash them into one.

Thank you for fixing the typos! It appears you went through a fairly random set of documentation, which leads me to a follow-up question: did you use an automated tool? If so, would you mind sharing with us which one you used? It would be great to add a typo check to our automated tests!

@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 1, 2022

$ make indent
make: *** No rule to make target 'indent'.  Stop.

How do I run it ?

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool -- thank you for the effort!

Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to run it from your build directory. You will also need to install clang-format for this purpose.

On the other hand, I just checked which lines the CI is actually reporting, and it's really just one line you need to fix. It's up to you if you pick make indent or fix the line directly.

examples/step-60/step-60.cc Outdated Show resolved Hide resolved
Co-authored-by: Marc Fehling <mafehling.git@gmail.com>
@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 1, 2022

/rebuild

@masterleinad masterleinad merged commit 66e0467 into dealii:master Dec 1, 2022
@luzpaz luzpaz deleted the typos/various branch December 1, 2022 13:35
@luzpaz
Copy link
Contributor Author

luzpaz commented Dec 1, 2022

@marcfehling i used the (latest dev version of) codespell and some deeper regex searches with vscode to root our some typos.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants