Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation of step-70. #14529

Merged
merged 1 commit into from Dec 3, 2022
Merged

Fix compilation of step-70. #14529

merged 1 commit into from Dec 3, 2022

Conversation

drwells
Copy link
Member

@drwells drwells commented Dec 3, 2022

I'm not sure how this ever worked. Unfortunately I only noticed the problem when updating the deal.II AUR package, so we need to patch this tutorial to get things compiling with all up-to-date dependencies.

I'm not sure how this ever worked.
@tjhei
Copy link
Member

tjhei commented Dec 3, 2022

Do we need a 9.4.2? :-(

@drwells
Copy link
Member Author

drwells commented Dec 3, 2022

Maybe? A better fix would be to ensure that whichever CI configurations compile examples also have opencascade installed.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a boost header is uncritical, though one may also just want to use standard C++ facilities to do this. There is only one place in the program where we use boost facilities, namely here:

        const auto extension = boost::algorithm::to_lower_copy(
          cad_file_name.substr(cad_file_name.find_last_of('.') + 1));

A simpler version without boost would be to use this call to std::transform: https://stackoverflow.com/questions/313970/how-to-convert-an-instance-of-stdstring-to-lower-case
If you want, I can make the corresponding change.

@tamiko
Copy link
Member

tamiko commented Dec 3, 2022

I guess it worked because some transitive dependency did include the right boost header.
Looking at the regression tester [1] and for the deal.II-9.4.1 version - we do indeed compile with opencascade.

I guess I would run into the same problem once I update the regression tester to the latest dependency versions again.

[1] https://cdash.dealii.org/index.php?project=deal.II

@tamiko tamiko merged commit 44af803 into dealii:master Dec 3, 2022
@tamiko
Copy link
Member

tamiko commented Dec 3, 2022

@bangerth Would you mind to make a pull request with a std::transform + std::tolower? I would prefer such a version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants