New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add get/set_mesh_smoothing to python bindings. #14549
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It would be nice if instead of exposing an integer, we would use an enum
(see here). Do you think that you could do it?
/rebuild |
I would like to have a try. |
I added the The following python code works on my machine. import PyDealII.Release as dealii
tria = dealii.Triangulation('2D', '3D', mesh_smoothing=dealii.MeshSmoothing.none, check_for_distorted_cells=False)
print(tria.get_mesh_smoothing())
tria.set_mesh_smoothing(dealii.MeshSmoothing.maximum_smoothing)
print(tria.get_mesh_smoothing())
tria = dealii.Triangulation('3D')
print(tria.get_mesh_smoothing())
tria.set_mesh_smoothing(dealii.MeshSmoothing.limit_level_difference_at_vertices)
print(tria.get_mesh_smoothing())
tria = dealii.Triangulation('3D', dealii.MeshSmoothing.limit_level_difference_at_vertices | dealii.MeshSmoothing.do_not_produce_unrefined_islands)
print(tria.get_mesh_smoothing()) Feel free to point out if I am doing something wrong. |
5bec747
to
d227613
Compare
This is great. Can you take the python code you used to check the code and add it as a test here |
d227613
to
c1f8ca3
Compare
This PR is ready for review now. |
Thanks a lot for the PR |
No description provided.