CMake: Bugfix: only export DEAL_II_GMSH_WITH_API if gmsh is configured #14550
Conversation
If the gmsh library is installed but the gmsh executable is missing we currently disable gmsh support. This implies that we will not link against the gmsh library. Unfortunately, on first configure pass the variable `GMSH_WITH_API` is still populated with a `TRUE` value and the `DEAL_II_GMSH_WITH_API` variable gets set by accident and final linkage fails. This issue is hard to spot because a second invocation of cmake will cure the configure mistake (and the debian/ubuntu packages do not run any autodetection).
|
/rebuild |
There was a problem hiding this comment.
I'm pretty sure this is right but I don't fully understand how this works. Before we tag a release I'll see if I can test this against a broken gmsh installation to make sure everything works or does not work as expected but I won't have time to do that until this evening.
|
@drwells Take your time. The "configure external" macro will only ever be called if we found gmsh. Thus, the variables is not set if gmsh wasn't found. |
|
I don't see how this is a problem since the relevant code is guarded against with |
|
Unfortunately, the code guard is |
|
There it is! |
If the gmsh library is installed but the gmsh executable is missing we
currently disable gmsh support. This implies that we will not link
against the gmsh library.
Unfortunately, on first configure pass the variable
GMSH_WITH_APIisstill populated with a
TRUEvalue and theDEAL_II_GMSH_WITH_APIvariable gets set by accident and final linkage fails.
This issue is hard to spot because a second invocation of cmake will
cure the configure mistake (and the debian/ubuntu packages do not run
any autodetection).