New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests: convert quick tests into regular tests #14558
Conversation
/rebuild |
# If we used message(SEND_ERROR ...) at the top (with the actual error | ||
# message) then subsequent messages (i.e., the test specific help) would not | ||
# be printed. Hence, do it down here. | ||
message(SEND_ERROR "") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This workaround has been unnecessary for a really long time...
|
0ad5f23
to
446a2f5
Compare
446a2f5
to
37d437e
Compare
oops I garbled the force push. Reponening |
11e78d4
to
84b4288
Compare
In reference to #1921 |
I guess this needs #14559? |
@masterleinad Yes, this requires #14559, I will rebase as soon as the other one is merged. |
84b4288
to
8bade6f
Compare
@masterleinad @peterrum Alright. This one is now ready for review (and ready to pass the testsuite ^^). |
This has irked me quite a bit: our quick tests duplicate a lot of
functionality that is already available in the testsuite proper. So,
instead of reinventing the wheel, let us simply use the testsuite itself.
The following pull request:
refactors all quick tests into regular tests that are configured for all
available build modes.
modifies the
test
target to properly depend on the libraryand the setup_tests_quick_tests target. This ensures that when calling
make test
orninja test
the library is compiled and quick tests areproperly configured.
the
test
target will now executerun_quick_tests.cmake
which doeslittle more than invoking
ctest -JN -R "quick_tests/(step.debug|step.release|affinity|.*.${_build_type})"
which mimicks the old behavior, meaning, we only run quick tests in one
configuration with the exception of the step and affinity tests.
Requires #14559