Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: quick test fixes for CI #14586

Merged
merged 2 commits into from Dec 20, 2022
Merged

CMake: quick test fixes for CI #14586

merged 2 commits into from Dec 20, 2022

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Dec 19, 2022

I accidentally introduced these when refactoring quick tests. This PR
ensures that we

  • do not trigger install during make test
  • return a non-zero exit code when quick tests fail

@tamiko
Copy link
Member Author

tamiko commented Dec 19, 2022

@tjhei ping

tjhei
tjhei approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@tjhei tjhei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect, thank you!

@tjhei
Copy link
Member

tjhei commented Dec 19, 2022

/rebuild

@tjhei
Copy link
Member

tjhei commented Dec 19, 2022

quick tests are now failing, but #14585 should fix that.

@masterleinad masterleinad merged commit c984db5 into dealii:master Dec 20, 2022
@masterleinad masterleinad deleted the quick_quick_tests_fix branch December 20, 2022 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

@drwells drwells drwells approved these changes

Assignees
No one assigned
Labels
Bug Build system ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tamiko @tjhei @drwells @masterleinad