Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken ADOL-C tests #14617

Merged
merged 3 commits into from Dec 28, 2022
Merged

Fix broken ADOL-C tests #14617

merged 3 commits into from Dec 28, 2022

Conversation

jppelteret
Copy link
Member

Fixes #14582

@jppelteret jppelteret mentioned this pull request Dec 27, 2022
Merged
@jppelteret
Copy link
Member Author

/rebuild

@jppelteret
Copy link
Member Author

@tjhei These test failures clearly show a deficiency in our coverage, so I appreciate that you've added a new CI build that will run ADOL-C with the refcounting flag enabled.

@masterleinad masterleinad merged commit f8bd841 into dealii:master Dec 28, 2022
@tjhei
Copy link
Member

tjhei commented Dec 28, 2022

Thank you, @jppelteret ! 👍

@jppelteret jppelteret deleted the bugfix_01 branch December 28, 2022 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masterleinad masterleinad masterleinad approved these changes

@tjhei tjhei Awaiting requested review from tjhei

Assignees
No one assigned
Labels
ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

adolc tests are broken
3 participants
@jppelteret @tjhei @masterleinad