Remove DEAL_II_COMPILER_CUDA_AWARE #14621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
force-pushed
the
remove_compiler_cuda_aware
branch
from
657b7bf
to
99dcf59
Compare
tamiko
approved these changes
Dec 29, 2022
|
/rebuild |
|
This needs to be rebased on master |
masterleinad
force-pushed
the
remove_compiler_cuda_aware
branch
from
99dcf59
to
3604e2f
Compare
Done. |
tjhei
approved these changes
Dec 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEAL_II_COMPILER_CUDA_AWAREis always true whenCUDAsupport is enabled. Hence, it makes more sense to useKOKKOS_ENABLE_CUDAinstead or use a different guard provided byKokkosfor code that should only be executed on the host or device (in case the function is annotated accordinlgy).This pull request simply removes
DEAL_II_COMPILER_CUDA_AWAREsince it doesn't seem likely that anyone would you use it outside ofdeal.IIbut we could, of course, also keep it for awhile.