CMake: Do not set errand DEAL_II_TRILINOS_WITH* if Trilinos gets disabled #14634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/rebuild |
tjhei
reviewed
Jan 3, 2023
| endif() | ||
| endif() | ||
|
|
||
| # the only thing we use from SEACAS right now is ExodusII, so just check | ||
| # that it works | ||
| if(${DEAL_II_TRILINOS_WITH_SEACAS}) | ||
| if(${TRILINOS_WITH_SEACAS}) |
There was a problem hiding this comment.
Why do you use if(${...}) here and below but not above on line 278? I assume this is redundant.
There was a problem hiding this comment.
Beats me. I just ran a search and replace on DEAL_II_TRILINOS and I chose to not alter the script too much in order to avoid mistakes (sans some whitespace fixes further down below where I couldn't resist).
masterleinad
approved these changes
Jan 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We accidentally already populate
DEAL_II_TRILINOSvariables while still deciding whether Trilinos support will be enabled or not. In case we decide to disable Trilinos support these variables were never cleaned up. This in combination with the recent change of making Trilinos support stricter, #14626, blew up the entire regression testsuite.In reference to #14631 #14626