Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue when adol-c is enabled #14643

Merged
merged 1 commit into from Jan 5, 2023
Merged

Fix issue when adol-c is enabled #14643

merged 1 commit into from Jan 5, 2023

Conversation

Rombur
Copy link
Member

@Rombur Rombur commented Jan 5, 2023

The problem is adol-c defines its own intrinsics in the global namespace. I fixed the problem by adding std:: when using older versions of Kokkos. The downside is that we lose support for some architectures/compilers but that can be fixed by updating the Kokkos version used.

Fixes #14642

@jppelteret
Copy link
Member

jppelteret commented Jan 5, 2023

Thanks for the fix! Might an alternative be to add using std::pow and using std::abs? This is what we do in numbers.h, for example. I think that this would prevent the downside that you've noted.

@Rombur
Copy link
Member Author

Rombur commented Jan 5, 2023

I would rather not to do that. What we do in numbers.h was the cause of a bug in my code that took me way too long to understand.

@jppelteret
Copy link
Member

I would rather not to do that.

Sure, I've got no problem with that.

@jppelteret jppelteret merged commit 1136eae into dealii:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image fails to build
3 participants