Replace ucd_to_deal with a local vertex numbering in GridGenerator #14673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jan 12, 2023
There was a problem hiding this comment.
Yes, nice job! This is exactly what I had had in mind. OK to merge if you were willing to address @masterleinad 's language suggestion.
nlsmrg
force-pushed
the
grid-generator-fix
branch
from
36801ec
to
bbbbd49
Compare
|
Done! I squashed the changes into one commit. |
|
/rebuild |
masterleinad
approved these changes
Jan 12, 2023
bangerth
approved these changes
Jan 12, 2023
|
Perfect! If you wanted to keep going down the list of places in #14608 where we use the array for reasons other than UCD in/output and fix those too, we'd be glad to take any patches you have! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #14608 (comment) this replaces the ucd_to_deal array with a local version of it for all occurrences in grid_generator.cc.