Configure: support KOKKOS when found with PETSc #14677
Conversation
This still require grabbing the compile flags and some special CUDA handling?
|
I think @tamiko is our expert here. :) |
|
Does |
|
We don't ship Kokkos source code. We link against an existing installation (that can also be automatically downloaded and built during PETSc configure) |
There was a problem hiding this comment.
We don't ship Kokkos source code. We link against an existing installation (that can also be automatically downloaded and built during PETSc configure)
In that case, I would rather require that we don't allow using the bundled Kokkos package but require Kokkos to be found as an external package and not import Kokkos flags from PETSc but rather from Kokkos directly. We treat Trilinos differently because they can't yet use an external Kokkos installation.
This way, we could also allow building deal.II with PETSc with Kokkos and Trilinos with Kokkos assuming that PETSc could use Trilinos' bundled Kokkos installation.
| @@ -26,7 +26,7 @@ set(KOKKOS_DIR "" CACHE PATH "An optional hint to a Kokkos installation") | |||
| set_if_empty(KOKKOS_DIR "$ENV{KOKKOS_DIR}") | |||
|
|
|||
|
|
|||
| if(DEAL_II_TRILINOS_WITH_KOKKOS) | |||
| if(DEAL_II_TRILINOS_WITH_KOKKOS OR DEAL_II_PETSC_WITH_KOKKOS) | |||
There was a problem hiding this comment.
| if(DEAL_II_TRILINOS_WITH_KOKKOS OR DEAL_II_PETSC_WITH_KOKKOS) | |
| if(DEAL_II_TRILINOS_WITH_KOKKOS) |
There was a problem hiding this comment.
I'm ok with this change. We probably need more automation and to provide hints to find_package to look into PETSc makefile variables KOKKOS_INCLUDE and KOKKOS_LIB
dealii/cmake/modules/FindDEAL_II_PETSC.cmake
Line 136 in a35e462
|
A couple of thoughts:
That said: I really want to get the CMake refactoring done now and I suggest the we hold off with changes to external features for about 2-4 weeks until said refactoring is done. Otherwise we will have nasty inflight collisions. Or have to fix problems twice. |
|
|
|
@tamiko This small change allows me to build and run using my PETSc install with KOKKOS dependency, otherwise there are a bunch of errors at runtime since PETSc and deal.II uses a different KOKKOS version. Can we merge this as is for now? Thanks for offering to improve it in the future, very much appreciated! |
|
@stefanozampini Fair enough. |
|
/rebuild |
This still require grabbing the compile flags and some special CUDA handling?
I'm not a CMAKE expert. I profoundly hate it. So if any CMAKE expert wants to pitch in and provide comments/suggestions/improvements, please go ahead @luca-heltai @bangerth