PETScWrappers::MPI::SparseMatrix: use SEQAIJ with one process #14683
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
reviewed
Jan 16, 2023
stefanozampini
force-pushed
the
stefanozampini/petsc-usematseqaij
branch
from
640cd0d
to
8439b7c
Compare
|
@bangerth This is ready to go. I have implemented the comments you requested |
bangerth
reviewed
Jan 17, 2023
Comment on lines
+439
to
+442
| // Here we both call the specific API since this is how | ||
| // PETSc polymorphism works. If the matrix is of type MPIAIJ, | ||
| // the second call is dummy. If the matrix is of type SEQAIJ, | ||
| // the first call is dummy. |
There was a problem hiding this comment.
Ah, fascinating. It's not a design I would have chosen, but ok :-)
bangerth
approved these changes
Jan 17, 2023
|
/rebuild |
|
We have an unrelated intermittend failure of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With one process, it is more efficient to use
MATSEQAIJSo, use
MATAIJto create the object (which is a proxy forSEQAIJin sequential andMPIAIJin parallel) and add missing preallocators