Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a comment for a recent patch. #14697

Merged
merged 1 commit into from
Jan 18, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
20 changes: 13 additions & 7 deletions source/grid/grid_reordering.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,23 @@ DEAL_II_NAMESPACE_OPEN
namespace
{
/**
* A set of functions that
* reorder the data from the
* "current" to the "classic"
* format of vertex numbering of
* cells and faces. These functions
* do the reordering of their
* arguments in-place.
* This file uses a different ordering for the vertices in a hex
* cell than we usually do in deal.II. The different convention used
* here originates in what we believed the ordering to be in UCD
* format, until it was discovered in 2022 that UCD will interpret
* this ordering to correspond to inverted cells -- as a
* consequence, the UCD ordering was fixed, but the current file is
* stuck on the old ordering.
*/
constexpr std::array<unsigned int, 8> local_vertex_numbering{
{0, 1, 5, 4, 2, 3, 7, 6}};

/**
* Following is a set of functions that reorder the data from the
* "current" to the "classic" format of vertex numbering of cells
* and faces. These functions do the reordering of their arguments
* in-place.
*/
void
reorder_new_to_old_style(std::vector<CellData<1>> &)
{}
Expand Down