Use initlog() in more tests. #14719
Merged
Use initlog() in more tests. #14719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamiko
requested changes
Jan 24, 2023
These required a small amount of manual tidying-up but the script I used to
generate most of the changes is
#!/usr/bin/env python3
import sys
lines = list()
skip_next_if_blank = False
with open(sys.argv[1], 'r') as handle:
for line in handle:
if line != 'std::ofstream logfile("output");\n':
if "deallog.attach" not in line:
if skip_next_if_blank and line == "\n":
pass
else:
lines.append(line.replace("logfile",
"deallog.get_file_stream()"))
skip_next_if_blank = False
else:
skip_next_if_blank = True
found_main = False
line_after_main = -1
with open(sys.argv[1], 'w') as handle:
for line in lines:
handle.write(line)
if line.startswith("main("):
found_main = True
if found_main:
line_after_main = line_after_main + 1
if line_after_main == 1:
handle.write(" initlog();\n")
|
The tests passed locally for me but it's worth cleaning things up - both comments should now be fixed in all files. |
masterleinad
approved these changes
Jan 24, 2023
bangerth
approved these changes
Jan 25, 2023
|
@tamiko is still blocking the merge. I'll let him comment/pull the trigger. |
tamiko
approved these changes
Jan 25, 2023
|
@bangerth Feel free to simply dismiss such a change request from me as "resolved" in the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #4250. I was reminded of this when reviewing one of the PETSc patches - its pretty easy to automatically convert many of these with a python script.