New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix find_all_active_cells_around_point() #14728
Fix find_all_active_cells_around_point() #14728
Conversation
This PR extends Previously if the pink point was requested within
@nmuch FYI |
2cf85c6
to
3102dd8
Compare
Ready to review from my side! |
/rebuild |
@mschreter Could you add a change-log entry? |
Co-authored-by: Magdalena Schreter <schreter.magdalena@gmail.com>
3102dd8
to
ca161a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mschreter Thanks 👍
@mschreter When looking at the picture in #14728 (comment), I think you are testing at the wrong place. It should be at (0.5, 0.25). Also would it be possible to switch the order of refinement. You have refined left. I would like to see also on the right. The motivation is that it makes the difference from which side the algorithm is run. |
I've tested (0.25,0.25), which is not a hanging node but is connected to cells at different levels. I thought this should be a critical point as well (not only hanging nodes). Nevertheless, I could extend the test case in a follow-up PR regarding (i) including a hanging node request and (ii) switching refinement direction. |
@mschreter Could you take over and add a test. Thx!