Test lac/parallel_vector_21: do not use KOKKOS_IMPL_DO_NOT_USE_PRINTF and indeed use printf #14730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drwells
approved these changes
Jan 26, 2023
|
/rebuild |
|
Does calling |
masterleinad
requested changes
Jan 26, 2023
|
@masterleinad Good point, I will update the pull request. |
tamiko
changed the title
|
@drwells @masterleinad Updated. |
masterleinad
requested changes
Jan 26, 2023
There was a problem hiding this comment.
No, you can't use printf in kernels in general. I would just remove the whole kernel, see #14733.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of Kokkos that come bundled with Trilinos older than 13.2
do not contain the KOKKOS_IMPL_DO_NOT_USE_PRINTF macro. Simply disable
the test in this case.