Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMake: do not use VERSION for interface targets for older CMake versions #14738

Merged
merged 1 commit into from Jan 27, 2023
Merged

CMake: do not use VERSION for interface targets for older CMake versions #14738

merged 1 commit into from Jan 27, 2023

Conversation

tamiko
Copy link
Member

@tamiko tamiko commented Jan 26, 2023

@drwells drwells changed the title CMake: do use VERSION for interface targets for older CMake versions CMake: do not use VERSION for interface targets for older CMake versions Jan 26, 2023
bangerth
bangerth reviewed Jan 26, 2023
View reviewed changes
Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if you fix the grammar problem in the comment.

cmake/macros/macro_define_interface_target.cmake Outdated Show resolved Hide resolved
@marcfehling marcfehling mentioned this pull request Jan 26, 2023
Closed
@drwells drwells merged commit 520c97a into dealii:master Jan 27, 2023
@tamiko tamiko deleted the make_older_cmake_happy branch July 7, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bangerth bangerth bangerth left review comments

@masterleinad masterleinad masterleinad approved these changes

@drwells drwells drwells approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Build system ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tamiko @masterleinad @drwells @bangerth @marcfehling