Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip "-x cuda" from Trilinos flags without configured Cuda support #14739

Merged
merged 1 commit into from Jan 27, 2023
Merged

Strip "-x cuda" from Trilinos flags without configured Cuda support #14739

merged 1 commit into from Jan 27, 2023

Conversation

masterleinad
Copy link
Member

Fixes #14711.

@marcfehling
Copy link
Member 

CMake Error at cmake/modules/FindDEAL_II_TRILINOS.cmake:155 (string):
  string sub-command REPLACE requires at least four arguments.
Call Stack (most recent call first):
  cmake/configure/configure_20_trilinos.cmake:35 (find_package)
  build/CMakeFiles/CMakeTmp/evaluate_expression.tmp:1 (feature_TRILINOS_find_external)
  cmake/macros/macro_evaluate_expression.cmake:30 (include)
  cmake/macros/macro_configure_feature.cmake:239 (evaluate_expression)
  cmake/configure/configure_20_trilinos.cmake:452 (configure_feature)
  cmake/macros/macro_verbose_include.cmake:19 (include)
  CMakeLists.txt:120 (verbose_include)

I guess it's because ${KOKKOS_COMPILE_FLAGS} could be empty?

@marcfehling marcfehling merged commit eb3bf71 into dealii:master Jan 27, 2023
@drwells drwells mentioned this pull request Jan 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tamiko tamiko tamiko approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
ready to test Reviewed and ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configuring with Trilinos somehow adds cuda flags on expanse
3 participants
@masterleinad @marcfehling @tamiko