Replace a ReferenceCell function call by a non-deprecated one. #14770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masterleinad
approved these changes
Feb 8, 2023
|
Ping? |
drwells
approved these changes
Feb 10, 2023
|
/rebuild |
|
/rebuild |
1 similar comment
|
/rebuild |
kronbichler
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReferenceCell::permute_according_orientationis now deprecated. Use the non-deprecated function instead. This also helps clean up the code slightly because the non-deprecated replacement returns an object of the right length, not one that might be longer than necessary.While there, I needed to learn about what kinds of objects are being passed around, and that prompted me to replace a few
autos by their actual types.One of these replacements changed the formatting, and then also the leading whitespace. The patch is probably best viewed without showing whitespace.