Improvements to the NOXSolver class documentation #14791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjhei
reviewed
Feb 13, 2023
sebproell
reviewed
Feb 13, 2023
singimarson
force-pushed
the
NOX_edits
branch
2 times, most recently
from
247d80a
to
f703dca
Compare
bangerth
reviewed
Feb 21, 2023
|
@singima Have you had time to think about the comments above? |
I have not, Ive been busy with preparing for my dissertation defense on the 30th. Once that's done I'll resume my work on it though! |
|
Sounds good. It is the season for defenses :-) Good luck! |
singimarson
force-pushed
the
NOX_edits
branch
2 times, most recently
from
3d444fa
to
100c71d
Compare
|
@bangerth sorry for the delay and for the fact that the PR might look different. Had a minor flub when trying to squash things, but I've made the changes you've suggested! |
bangerth
approved these changes
Apr 11, 2023
| * A user function that computes the residual @p f based on the | ||
| * current solution @p x. | ||
| * A function object that users should supply and that is intended to | ||
| * compute the residual `u = F(u)`. |
There was a problem hiding this comment.
Suggested change
| * compute the residual `u = F(u)`. | |
| * compute the residual $F(u)$. |
|
I'll make the one left-over change myself in a second. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.