fix wrong sign of char in MF #14797
Merged
fix wrong sign of char in MF #14797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On ARM char defaults to unsigned char, which will break the matrix free face loop. Fix this by being explicit. Fixes: /home/ubuntu/dealii-9.4.2/include/deal.II/matrix_free/face_setup_internal.h:522:35: warning: comparison is always false due to limited range of data type [-Wtype-limits]
|
... and yes, the standard says char can be signed or unsigned. Sigh. |
peterrum
approved these changes
Feb 14, 2023
masterleinad
approved these changes
Feb 14, 2023
kronbichler
approved these changes
Feb 14, 2023
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some ARM systems
chardefaults tounsigned char, which will break the matrix free face loop. Fix this by being explicit.Fixes:
/home/ubuntu/dealii-9.4.2/include/deal.II/matrix_free/face_setup_internal.h:522:35: warning: comparison is always false due to limited range of data type [-Wtype-limits]