FieldTransfer: enable coarsening #14802
Conversation
|
I agree that |
| const auto &fe = dof_handler.get_fe(fe_index); | ||
| Assert(fe.n_dofs_per_cell() > 0, | ||
| ExcMessage( | ||
| "Cannot coarsen onto a FiniteElement with no DoFs.")); |
There was a problem hiding this comment.
Is that true even if all the children cells use FE_Nothing?
There was a problem hiding this comment.
I think the FE here (returned by the domination logic) should never be FE_Nothing.
tests/hp/field_transfer_05.cc
Outdated
| { | ||
| if (cell->is_locally_owned()) | ||
| { | ||
| if (cell->center()[0] < 0.5) |
There was a problem hiding this comment.
Can you add a test where you coarsen FE_Nothing cells
There was a problem hiding this comment.
I added it but now I get an error (floating point exception in LAPACKFullMatrix::vmult inside interpolate) when trying to resolve the hanging node constraints.
There was a problem hiding this comment.
OK it is a weird thing to do anyway. I would be fine merging this PR which improves the current situation, if you open an issue that describes the problem.
sebproell
force-pushed
the
field-transfer-coarsening
branch
from
df58baf
to
d42cd5f
Compare
As of now I can only refer to the initial idea I had here #11132 (comment), and here #12759 (comment) (and the follow-up discussion). I cannot work on this topic right now as of immediate deadlines ahead. I will have time in spring to put more thought into it. We should also fix the remaining issues with |
|
/rebuild |
The new
FieldTransferclass does not seem to be able to coarsen a non-constant FE field. This PR suggests a way to achieve this, similar toSolutionTransfer.remark: I am not super happy with the implementation, since this functionality is mostly copied and adapted from
SolutionTransferandget_interpolated_dof_values. OverallFieldTransferandSolutionTransfershare a lot of functionality but differ in certain details. There was some discussion how to best implement the requirements some of us have on transfer of field vectors in #12759. I would be happy to help in future development of these classes. Actually, I also require the averaging functionality ofSolutionTransferintroduced in #13457.