Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unused variable warning #14805

Merged
merged 1 commit into from Feb 17, 2023
Merged

fix unused variable warning #14805

merged 1 commit into from Feb 17, 2023

Conversation

tjhei
Copy link
Member

@tjhei tjhei commented Feb 15, 2023

It turns out that iteration is never read from in release mode because Assert() only triggers in debug mode.

I am not sure what behavior we would like to have in release mode here, but this proposed change will get rid of the warning.

It turns out that ``iteration`` is never read from in release mode
because Assert() only triggers in debug mode.

I am not sure what behavior we would like to have in release mode here,
but this proposed change will get rid of the warning.
Copy link
Member

@drwells drwells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In similar places (like failing to invert the unit-to-cell mapping) we also throw exceptions so this makes sense.

@masterleinad masterleinad merged commit 879a491 into dealii:master Feb 17, 2023
@tjhei tjhei deleted the manifold-warn branch February 17, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants