New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only instantiate TpetraWrappers::Vector for types that have explicit instantiations in Tpetra #14824
Only instantiate TpetraWrappers::Vector for types that have explicit instantiations in Tpetra #14824
Conversation
/rebuild |
@masterleinad Thanks! We will probably need to merge, since the docker image is only built once the PR is merged. |
Also fixing the failures in https://github.com/dealii/dealii/actions/runs/4235947222/jobs/7360188695 (hopefully).
Yes, fixing the docker image is always a little poking in the dark. 🙁 |
Just push your proposed changes to dealii/dealii with a branch name that starts with "docker", see dealii/.github/workflows/docker.yml Line 6 in 3b78517
|
It is indeed... |
See https://github.com/dealii/dealii/tree/docker_restrict_tpetra_vector_instantiations |
18c3555
to
a758ada
Compare
The tests are a bit tricky since the output will depend on the available number types. We only check for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's give this a try!
FIxes #14815.