Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only instantiate TpetraWrappers::Vector for types that have explicit instantiations in Tpetra #14824

Merged

Conversation

masterleinad
Copy link
Member

FIxes #14815.

@masterleinad
Copy link
Member Author

/rebuild

@peterrum
Copy link
Member

@masterleinad Thanks! We will probably need to merge, since the docker image is only built once the PR is merged.

@masterleinad
Copy link
Member Author

Also fixing the failures in https://github.com/dealii/dealii/actions/runs/4235947222/jobs/7360188695 (hopefully).

@masterleinad Thanks! We will probably need to merge, since the docker image is only built once the PR is merged.

Yes, fixing the docker image is always a little poking in the dark. 🙁

@tjhei
Copy link
Member

tjhei commented Feb 23, 2023

Yes, fixing the docker image is always a little poking in the dark.

Just push your proposed changes to dealii/dealii with a branch name that starts with "docker", see

@blaisb
Copy link
Member

blaisb commented Feb 23, 2023

Also fixing the failures in https://github.com/dealii/dealii/actions/runs/4235947222/jobs/7360188695 (hopefully).

@masterleinad Thanks! We will probably need to merge, since the docker image is only built once the PR is merged.

Yes, fixing the docker image is always a little poking in the dark. slightly_frowning_face

It is indeed...

@masterleinad
Copy link
Member Author

Just push your proposed changes to dealii/dealii with a branch name that starts with "docker", see

See https://github.com/dealii/dealii/tree/docker_restrict_tpetra_vector_instantiations

@masterleinad masterleinad force-pushed the restrict_tpetra_vector_instantiations branch from 18c3555 to a758ada Compare February 24, 2023 15:52
@masterleinad masterleinad marked this pull request as ready for review February 24, 2023 16:00
@masterleinad
Copy link
Member Author

The tests are a bit tricky since the output will depend on the available number types. We only check for double in TPETRA_IS_FUNCTIONAL so I would just drop the tests for other number types for now.

Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's give this a try!

@peterrum peterrum merged commit ca078c7 into dealii:master Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image has issues linking with Trilinos
4 participants