Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Mapping::get_center() work with simplices. #14829

Merged
merged 1 commit into from Mar 3, 2023

Conversation

drwells
Copy link
Member

@drwells drwells commented Feb 25, 2023

I saw this when looking at #14727.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, but would you mind adding a test? You could create meshes via GridGenerator::reference_cell() and then translate/rotate the mesh.

@drwells
Copy link
Member Author

drwells commented Feb 26, 2023

I added a more involved test which uses a nonlinear deformation of the geometry.

include/deal.II/fe/mapping.h Outdated Show resolved Hide resolved
@kronbichler
Copy link
Member

I think you need to rebase.

@masterleinad masterleinad merged commit 4234dae into dealii:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants