Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SymmetricTensor access returns const reference #14839

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion include/deal.II/base/symmetric_tensor.h
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@ namespace internal
{
using tensor_type = const ::dealii::SymmetricTensor<rank, dim, Number>;

using reference = Number;
using reference = const Number &;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the question is whether we want to expose the underlying memory address (as with a reference) or not (then, the right type would be const Number;). I agree with the current patch.

};

/**
Expand Down
43 changes: 43 additions & 0 deletions tests/tensors/symmetric_tensor_46.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
// ---------------------------------------------------------------------
//
// Copyright (C) 2023 by the deal.II authors
//
// This file is part of the deal.II library.
//
// The deal.II library is free software; you can use it, redistribute
// it, and/or modify it under the terms of the GNU Lesser General
// Public License as published by the Free Software Foundation; either
// version 2.1 of the License, or (at your option) any later version.
// The full text of the license can be found in the file LICENSE.md at
// the top level directory of deal.II.
//
// ---------------------------------------------------------------------


// Test that a const SymmetricTensor is not assignable, i.e., the accessors
// return a const reference

#include <deal.II/base/symmetric_tensor.h>
#include <deal.II/base/tensor.h>
#include <deal.II/base/vectorization.h>

#include "../tests.h"

int
main()
{
initlog();

{
const SymmetricTensor<2, 3, double> st{};
static_assert(std::is_same<decltype(st[0][0]), const double &>::value);
}

{
const SymmetricTensor<2, 3, VectorizedArray<double>> stv{};
static_assert(std::is_same<decltype(stv[0][0]),
const VectorizedArray<double> &>::value);
}

deallog << "OK" << std::endl;
}
2 changes: 2 additions & 0 deletions tests/tensors/symmetric_tensor_46.output
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@

DEAL::OK