Redo some indexing inside FESystem. #14878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
approved these changes
Mar 13, 2023
|
OK otherwise! |
This function takes up about 3% of the total runtime for an application I'm working on. We can reduce that cost by nearly 50% by moving some checks outside of loops and explicitly using std::copy(), which assumes the inputs are not aliased, rather than for-loops.
drwells
force-pushed
the
redo-fe-system-copy
branch
from
d0455a5
to
692e651
Compare
kronbichler
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function takes up about 3% of the total runtime for an application I'm working on. We can reduce that cost by nearly 50% by moving some checks outside of loops and explicitly using
std::copy(), which ultimately results in the compiler callingmemcpy()(it can't do that on the present version due to aliasing).