Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to ensure consistent constraints in parallel #14907

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kronbichler
Copy link
Member

This is the test needed for #14905. I added it as a separate PR as it can currently run (but would fail to produce a reasonable output). The idea of the test is to set up constraints for a DoF owned at process with index 0, but defined only from information on processes with rank 1 and 2. The problem to be represented is that neither of process 1 and 2 have the full information on the constraints, and only their combined form represents the valid state.

Copy link
Member

@bangerth bangerth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is ok to merge. Out of curiosity, what is the situation you were considering that triggered this whole thing?

@bangerth
Copy link
Member

(Ok to merge = once #14905 is merged and this is rebased.)

@@ -0,0 +1,17 @@
Working on rank 0 of 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the output already generated with #14905?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this uses the code of #14905.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure that the output is up to date? Where is Working on rank coming from and why do not all processes output Output 0, Output 1, and Output 2?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The output should be:


DEAL:0::Output 0
DEAL:0::Output 1
    0 1:  0.500000
    0 3:  0.500000
    0 2:  0.500000
    2 3:  1.50000
DEAL:0::Output 2
    0 1:  0.500000
    0 3:  1.25000
    2 3:  1.50000

DEAL:1::Output 0
    0 1:  0.500000
    0 2:  0.500000
    2 3:  1.50000
DEAL:1::Output 1
    0 1:  0.500000
    0 3:  0.500000
    0 2:  0.500000
    2 3:  1.50000
DEAL:1::Output 2
    0 1:  0.500000
    0 3:  1.25000
    2 3:  1.50000


DEAL:2::Output 0
    0 1:  0.500000
    0 3:  0.500000
DEAL:2::Output 1
    0 1:  0.500000
    0 3:  0.500000
    0 2:  0.500000
    2 3:  1.50000
DEAL:2::Output 2
    0 1:  0.500000
    0 3:  1.25000
    2 3:  1.50000

Copy link
Member

@peterrum peterrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kronbichler Could you rename the file to tests/lac/constraints_make_consistent_in_parallel_02.cc so that the AC::make_consistent_in_parallel() are at the same place!?

@kronbichler
Copy link
Member Author

Could you rename the file to tests/lac/constraints_make_consistent_in_parallel_02.cc so that the AC::make_consistent_in_parallel() are at the same place!?

I will adapt the output once #14905 is merged. Regarding the name, I used the mpi/constraints_consistent_01.cc as a template, so we have a conflict. I can move that file to the lac subfolder, too, as it feels that all the three tests should be in the same place.

@tamiko tamiko added this to the Release 9.6 milestone Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants