[C++20] Apply concepts in parallel.h. #14933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangerth
commented
Mar 21, 2023
Comment on lines
-110
to
+114
| * predicate(*in++)</code> where the <code>in</code> iterator ranges over | ||
| * function(*in++)</code> where the <code>in</code> iterator ranges over |
There was a problem hiding this comment.
There are a number of places in this file that used the word "predicate" instead of "function object". This was uniformly wrong in this file: a "predicate" is a function that returns a bool, but the ones in this file do generally not. I fixed this while here, both in the documentation, in variable names, and in template type names.
masterleinad
approved these changes
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for #14840.
parallel.hhas many places where we take an invokable object and apply it to certain arguments. This patch adds the relevant concepts to ensure that the types match their constraints.