Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some extra 'dealii::'s. #14942

Merged
merged 5 commits into from Mar 23, 2023
Merged

Clean up some extra 'dealii::'s. #14942

merged 5 commits into from Mar 23, 2023

Conversation

drwells
Copy link
Member

@drwells drwells commented Mar 22, 2023

No description provided.

marcfehling
marcfehling approved these changes Mar 22, 2023
View reviewed changes
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

include/deal.II/dofs/dof_accessor.templates.h Show resolved Hide resolved
include/deal.II/dofs/dof_accessor.templates.h Outdated Show resolved Hide resolved
@marcfehling
Copy link
Member

Some doxygen warnings

[100%] Built target documentation
/home/runner/work/dealii/dealii/source/base/quadrature_lib.cc:2251: warning: no matching class member found for 
  template Quadrature< 3 > QSimplex< 2 >::compute_affine_transformation(const std::array< Point< 3 >, 2+1 > &vertices) const

/home/runner/work/dealii/dealii/source/base/quadrature_lib.cc:2263: warning: no matching class member found for 
  template Quadrature< 2 > QSimplex< 2 >::mapped_quadrature(const std::vector< std::array< Point< 2 >, 2+1 >> &simplices) const

/home/runner/work/dealii/dealii/source/base/quadrature_lib.cc:2267: warning: no matching class member found for 
  template Quadrature< 3 > QSimplex< 2 >::mapped_quadrature(const std::vector< std::array< Point< 3 >, 2+1 >> &simplices) const

warning: Inheritance graph for 'SmartPointer' not generated, too many nodes (138), threshold is 50. Consider increasing DOT_GRAPH_MAX_NODES.
warning: Inheritance graph for 'Subscriptor' not generated, too many nodes (195), threshold is 50. Consider increasing DOT_GRAPH_MAX_NODES.

@drwells drwells force-pushed the remove-extra-namespace branch 2 times, most recently from 8312c2b to 5635615 Compare March 22, 2023 13:40
@drwells drwells mentioned this pull request Mar 22, 2023
Merged
tjhei
tjhei approved these changes Mar 22, 2023
View reviewed changes
include/deal.II/multigrid/multigrid.h Outdated Show resolved Hide resolved
include/deal.II/multigrid/multigrid.h Outdated Show resolved Hide resolved
@masterleinad masterleinad merged commit 92344eb into dealii:master Mar 23, 2023
11 checks passed
@drwells drwells mentioned this pull request Apr 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjhei tjhei tjhei approved these changes

@kronbichler kronbichler kronbichler approved these changes

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Miscellaneous ready to test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@drwells @marcfehling @tjhei @kronbichler @masterleinad