Work on ShapeInfo::is_supported() #14953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterrum
commented
Mar 23, 2023
Comment on lines
+401
to
+406
| dynamic_cast<const FE_SimplexPoly<dim, dim> *>( | ||
| &fe_in.base_element(base_element_number)) != nullptr || | ||
| dynamic_cast<const FE_WedgePoly<dim, dim> *>( | ||
| &fe_in.base_element(base_element_number)) != nullptr || | ||
| dynamic_cast<const FE_PyramidPoly<dim, dim> *>( | ||
| &fe_in.base_element(base_element_number)) != nullptr) |
There was a problem hiding this comment.
This was not correct and not an issue, since the first condition normally is true.
| @@ -383,7 +383,20 @@ namespace internal | |||
| const unsigned int base_element = 0); | |||
|
|
|||
| /** | |||
| * Return which kinds of elements are supported by MatrixFree. | |||
| * Return whether an element is supported by MatrixFree. | |||
There was a problem hiding this comment.
@kronbichler Have I missed any finite elements?
kronbichler
approved these changes
Mar 24, 2023
peterrum
force-pushed
the
si_is_supported
branch
from
ade1d7e
to
80754a7
Compare
kronbichler
approved these changes
Mar 25, 2023
|
/rebuild |
peterrum
force-pushed
the
si_is_supported
branch
from
80754a7
to
2c0f378
Compare
peterrum
commented
Mar 26, 2023
| @@ -16,7 +16,7 @@ DEAL::FE_FaceP<2>(1) supported by MatrixFree: false | |||
| DEAL::FE_FaceQ<2>(1) supported by MatrixFree: false | |||
| DEAL::FE_P1NC supported by MatrixFree: false | |||
| DEAL::FE_Nedelec<2>(1) supported by MatrixFree: false | |||
| DEAL::FE_Nothing<2>() supported by MatrixFree: false | |||
| DEAL::FE_Nothing<2>() supported by MatrixFree: true | |||
There was a problem hiding this comment.
2 new supported elements :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.