Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave a hint in step-7. #14987

Merged
merged 2 commits into from Apr 19, 2023
Merged

Leave a hint in step-7. #14987

merged 2 commits into from Apr 19, 2023

Conversation

bangerth
Copy link
Member

This has apparently been sitting in my github for a year now...

Copy link
Member

@kronbichler kronbichler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small suggestion.

Regarding the last comment about an solver, I wonder if we should give more explicit hints. Among the many works which have done this, one example pretty close to the step-7 tutorial program, is Figure 5 of https://doi.org/10.1137/16M110455X, including a comparison of different polynomial degrees and different kinds of solvers (matrix-free, matrix-based, continuous FEM, DG, HDG). That is my own paper, so I feel conflicted to suggest including that link (also, it is not open-access), but I think a reader might want to read what we consider state-of-the-art.

Comment on lines 294 to 295
of unknowns by timing each refinement step (e.g., using the Timer
class), you will notice that the linear solver is not perfect -- its
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
of unknowns by timing each refinement step (e.g., using the Timer
class), you will notice that the linear solver is not perfect -- its
of unknowns by timing each refinement step,
you will notice that the linear solver is not perfect -- its

@bangerth
Copy link
Member Author

Excellent idea. I added the reference, I think it's quite useful!

@bangerth
Copy link
Member Author

bangerth commented Apr 5, 2023

Ping?

@bangerth
Copy link
Member Author

Could I interest someone to hit the button on this one?

@drwells drwells merged commit 4a804d0 into dealii:master Apr 19, 2023
10 of 11 checks passed
@bangerth bangerth deleted the 7 branch April 19, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants