Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better document FEInterfaceValues::reinit(). #15097

Merged
merged 2 commits into from Apr 14, 2023
Merged

Better document FEInterfaceValues::reinit(). #15097

merged 2 commits into from Apr 14, 2023

Conversation

bangerth
Copy link
Member

Fixes #15094.

marcfehling
marcfehling requested changes Apr 14, 2023
View reviewed changes
Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and clarifies the usage!

Can you also update the parameters descriptions in the next function?

@bangerth
Copy link
Member Author

I've also updated the documentation of the other function. Thanks for pointing it out, I somehow managed to miss its existence.

@marcfehling marcfehling merged commit 6ca2586 into dealii:master Apr 14, 2023
11 of 14 checks passed
@bangerth bangerth deleted the fe-interface-values-1 branch April 14, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcfehling marcfehling marcfehling approved these changes

Assignees
No one assigned
Labels
Documentation Finite Element
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the logic in FEInterfaceValues::reinit()
2 participants
@bangerth @marcfehling