extend distributed_compute_point_locations #15101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jh66637
force-pushed
the
extend_distributed_compute_point_locations
branch
from
053a158
to
9b767ed
Compare
peterrum
approved these changes
Apr 14, 2023
Comment on lines
+1172
to
+1179
| const double tolerance = 1e-10, | ||
| const std::vector<bool> & marked_vertices = {}, | ||
| const bool enforce_unique_mapping = true); |
There was a problem hiding this comment.
I guess the different ordering of the parameters in comparison to the one of the internal function is a bit annoying but we cannot change that.
There was a problem hiding this comment.
I was thinking about the same thing. I think even if we could change it without problems within deal.II (what I am not sure about), it might break user code. Thus, I refrained from this.
|
/rebuild |
kronbichler
approved these changes
Apr 14, 2023
…ocations Co-authored-by: Martin Kronbichler <martin.kronbichler@uni-a.de>
jh66637
force-pushed
the
extend_distributed_compute_point_locations
branch
from
c845900
to
886935d
Compare
|
/rebuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to use
distributed_compute_point_locationsin combination withenforce_unique_mapping=false. Since this function just calls the internal one, the needed changes are just to forward the arguments. I also addedmarked_vferticesto the function signature to be able to specify it as well.@peterrum