Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an example to the documentation of GridTools::transform(). #15120

Merged
merged 1 commit into from Apr 21, 2023

Conversation

bangerth
Copy link
Member

No description provided.

Copy link
Member

@marcfehling marcfehling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have two suggestions.

Comment on lines 559 to 560
* transformation -- one that simply moves the object two units to the
* right -- could like as follows:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* transformation -- one that simply moves the object two units to the
* right -- could like as follows:
* transformation -- one that simply moves the object two units in
* $x$-direction -- could look like this:

I would also specify the coordinate direction. And something's off in the main sentence.

@bangerth
Copy link
Member Author

I've implemented something like what you suggest!

@marcfehling marcfehling merged commit e68c9b8 into dealii:master Apr 21, 2023
11 of 14 checks passed
@bangerth bangerth deleted the doc-64 branch April 21, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants