Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement arbitrary order derivatives for tensor-product evaluators #15124

Merged
merged 2 commits into from Apr 22, 2023

Conversation

kronbichler
Copy link
Member

This PR is a preparation for an upcoming one (that simplifies the internals of MappingQ), and implements arbitrary order derivatives for the code path of tensor-product evaluators on arbitrary points, the data structure underlying FEPointEvaluation for example. The derivatives are returned in compressed format, using all symmetries that are in the higher order derivatives (such as symmetry in the Hessian), thus returning a unrolled tensor.

@bangerth
Copy link
Member

There are test failures:

/jenkins/workspace/dealii-serial_PR-15124/tests/matrix_free/tensor_product_evaluate_08.cc: In function ‘void test(unsigned int)’:
/jenkins/workspace/dealii-serial_PR-15124/tests/matrix_free/tensor_product_evaluate_08.cc:66:27: error: missing template arguments before ‘monomial’
   66 |       Functions::Monomial monomial(exp);
      |                           ^~~~~~~~
/jenkins/workspace/dealii-serial_PR-15124/tests/matrix_free/tensor_product_evaluate_08.cc:68:30: error: ‘monomial’ was not declared in this scope; did you mean ‘polynomials’?
   68 |         function_values[i] = monomial.value(fe.get_unit_support_points()[i]);
      |                              ^~~~~~~~
      |                              polynomials
make[3]: *** [CMakeFiles/matrix_free.tensor_product_evaluate_08.debug.dir/build.make:76: CMakeFiles/matrix_free.tensor_product_evaluate_08.debug.dir/tensor_product_evaluate_08.cc.o] Error 1
make[2]: *** [CMakeFiles/Makefile2:694: CMakeFiles/matrix_free.tensor_product_evaluate_08.debug.dir/all] Error 2
make[1]: *** [CMakeFiles/Makefile2:649: CMakeFiles/matrix_free.tensor_product_evaluate_08.debug.test.dir/rule] Error 2
make: *** [Makefile:212: matrix_free.tensor_product_evaluate_08.debug.test] Error 2
Test matrix_free/tensor_product_evaluate_08.debug: BUILD
===============================   OUTPUT BEGIN  ===============================
matrix_free/tensor_product_evaluate_08.debug: BUILD failed. Output:
Building CXX object CMakeFiles/matrix_free.tensor_product_evaluate_08.debug.dir/tensor_product_evaluate_08.cc.o

@drwells drwells merged commit ae3c6b0 into dealii:master Apr 22, 2023
14 checks passed
@kronbichler kronbichler deleted the tensor_product_higher_derivs branch August 10, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants